-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using azure workload identity requires using a deprecated side car injection #5353
Comments
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
pls keep open |
Maybe this is related? thanos-io/objstore#82 |
Thank you @yeya24 Can be merged to cortex ? |
@alexku7 I merged that pr. I will update Cortex with that. Just FYI, it will be on master so not on latest release v1.16.0 |
Thanks @yeya24 👏🏼 When is this going to be released? |
It will be included in v1.17.0. |
Describe the bug
Cortex supports using the Azure workload identity when the AKS cluster is used for Cortex deployment.
However, Cortex uses a deprecated method to get the token from the IMDS metadata.
This approach required to put the annotation
azure.workload.identity/inject-proxy-sidecar: true
in order to inject a special side car. Microsoft deprecated this methodCortex should upgrade the Azure SDK and use automatically the env vars , such as
AZURE_CLIENT_ID
AZURE_TENANT_ID
AZURE_FEDERATED_TOKEN_FILE
The variables are injected automatically by Azure workload identity admission hook:
The text was updated successfully, but these errors were encountered: