Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using azure workload identity requires using a deprecated side car injection #5353

Closed
alexku7 opened this issue May 21, 2023 · 7 comments · Fixed by #5645
Closed

Using azure workload identity requires using a deprecated side car injection #5353

alexku7 opened this issue May 21, 2023 · 7 comments · Fixed by #5645

Comments

@alexku7
Copy link
Contributor

alexku7 commented May 21, 2023

Describe the bug
Cortex supports using the Azure workload identity when the AKS cluster is used for Cortex deployment.
However, Cortex uses a deprecated method to get the token from the IMDS metadata.
This approach required to put the annotation azure.workload.identity/inject-proxy-sidecar: true in order to inject a special side car. Microsoft deprecated this method

Cortex should upgrade the Azure SDK and use automatically the env vars , such as

AZURE_CLIENT_ID
AZURE_TENANT_ID
AZURE_FEDERATED_TOKEN_FILE

The variables are injected automatically by Azure workload identity admission hook:

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@alexku7
Copy link
Contributor Author

alexku7 commented Sep 17, 2023

pls keep open

@stale stale bot added the stale label Sep 17, 2023
@yeya24
Copy link
Contributor

yeya24 commented Nov 10, 2023

Maybe this is related? thanos-io/objstore#82
I wonder if we can have this pr merged, whether it helps resolve this issue or not. @alexku7 Maybe you can help take a look?

@stale stale bot removed the stale label Nov 10, 2023
@alexku7
Copy link
Contributor Author

alexku7 commented Nov 12, 2023

Thank you @yeya24
Indeed it looks like the correct solution :)

Can be merged to cortex ?

@yeya24
Copy link
Contributor

yeya24 commented Nov 12, 2023

@alexku7 I merged that pr. I will update Cortex with that. Just FYI, it will be on master so not on latest release v1.16.0

@SatyKrish
Copy link

Thanks @yeya24 👏🏼

When is this going to be released?

@yeya24
Copy link
Contributor

yeya24 commented Dec 17, 2023

It will be included in v1.17.0.
You can use master image for now or cherry-pick that commit to 1.16.0 branch and build the image on your own

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants