Migration from v0.46 to v0.47 (and III) - update export.go & modules.go

[RaulBernal]

Hi guys, I was adapting the export.go file replacing it by:

genState := app.ModuleManager.ExportGenesisForModules(ctx, app.appCodec, modulesToExport)

and now I'm wondering if we need to adapt our whole x/bcna/modules.go to the Simapp standard

Is also necessary update all the functions inside and use the NewManager & the bm BasicManager etc ?

By the moment (a new testnet) is working fine with app.mm. form.

[julienrbrt]

Do you mean the difference between mm and ModuleManager?
We've simply renamed the variable/field for clarity. Changing the name will not change the behavior.
Or have I misunderstood your question?

[RaulBernal]

Maybe I mixed two questions in one.

1. Yes I wanted to know why the name change; I checked it deeply and now understand was a stupid question. Thank you for clarification.

2. This is the important question: is my exporting function is fine with v0.47 ?
   I compare mine with yours and I find a lot of new additions to module.go

[julienrbrt]

ExportGenesis has not changed in v0.47 (https://github.com/cosmos/cosmos-sdk/blob/main/types/module/module.go#L528). We've added support to Core API ExportGenesis method as well, but for you, there are no changes to do in your modules.