Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Cosmovisor: Configurable Data directory path instead of hard-coded one #20947

Open
0x4r45h opened this issue Jul 13, 2024 · 2 comments · May be fixed by #21971
Open

[Feature]: Cosmovisor: Configurable Data directory path instead of hard-coded one #20947

0x4r45h opened this issue Jul 13, 2024 · 2 comments · May be fixed by #21971
Assignees
Labels
C:Cosmovisor Issues and PR related to Cosmovisor T:feature-request

Comments

@0x4r45h
Copy link

0x4r45h commented Jul 13, 2024

Summary

The current $DAEMON_HOME location is dependent on the data directory and must be set to the same directory as the application data directory, it would be helpful to let the user decouple these two by setting an optional config for the data directory path

Problem Definition

Users are forced to place cosmovisor inside the application home directory (e.g., $HOME/.simapp), so it can detect upgrade-info.json and perform backups from the data directory.

One case where this can add complexity to the setup is using Cosmovisor inside Docker images. In Docker setups, it is trivial to mount the whole application home directory (e.g., $HOME/.simapp) to a persistent Docker volume, but cosmovisor should be outside of this volume so its underlying binaries can get updated by pulling new image versions.

Proposed Feature

Add an optional configuration like daemon_data_dir to allow users to specify an absolute path to the application data directory, such as /home/bob/.simapp/data. If left empty, it will default to the current behavior, which is $DAEMON_HOME/data.

@0x4r45h
Copy link
Author

0x4r45h commented Aug 3, 2024

@julienrbrt Sorry for tagging, I have PR attached to this. could you please give feedback when you have time

@julienrbrt
Copy link
Member

Hey, it sounds like a good addition. We just really need to make sure the upgrade-info is still detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment