Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make System Test V2 pass #22753

Open
9 tasks done
julienrbrt opened this issue Dec 4, 2024 · 2 comments · May be fixed by #22849
Open
9 tasks done

Make System Test V2 pass #22753

julienrbrt opened this issue Dec 4, 2024 · 2 comments · May be fixed by #22849
Assignees
@julienrbrt @hieuvubk
Labels
C:server/v2 Issues related to server/v2 T: Tests

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Dec 4, 2024 •
edited
Loading

One of the last thing to do for v2 is make the system tests be green.

How to?

Run the following command and fix all issues until it passes.
This tracking issue can be closed once CI is green on this job.
PRs can be split to fix issue by issue.

COSMOS_BUILD_OPTIONS=v2 make test-system

Following an exhaustive list:
@julienrbrt julienrbrt added C:server/v2 Issues related to server/v2 T: Tests labels Dec 4, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Dec 4, 2024
@hieuvubk hieuvubk self-assigned this Dec 5, 2024
@hieuvubk hieuvubk moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Dec 5, 2024
@julienrbrt julienrbrt self-assigned this Dec 5, 2024
@julienrbrt julienrbrt mentioned this issue Dec 5, 2024
Merged
12 tasks
@mmsqe mmsqe mentioned this issue Dec 6, 2024
Merged
12 tasks
This was referenced Dec 6, 2024
Merged
Merged
@julienrbrt julienrbrt mentioned this issue Dec 6, 2024
Merged
12 tasks
@mergify mergify bot mentioned this issue Dec 6, 2024
Merged
12 tasks
@julienrbrt
Copy link
Member Author

I am seeing some system tests being flaky and failing with:
It should be investigated as well.

7.0.0.1:58516
8< chain err -----------------------------------------
err> panic: runtime error: invalid memory address or nil pointer dereference
err> [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x133942c]
err> 
err> goroutine 159 [running]:
err> github.com/cosmos/iavl.(*MutableTree).set(0x4001076d20, {0x4002cbb168?, 0x1?, 0x14b4d88?}, {0x5a85540?, 0x4001122e80?, 0x4000e4bb08?})
err>    github.com/cosmos/[email protected]/mutable_tree.go:262 +0x2c
err> github.com/cosmos/iavl.(*MutableTree).Set(...)
err>    github.com/cosmos/[email protected]/mutable_tree.go:172
err> cosmossdk.io/store/v2/commitment/iavl.(*IavlTree).Set(0x2d585e0?, {0x4002cbb168?, 0x4001f76ad8?, 0x6?}, {0x5a85540?, 0x0?, 0x0?})
err>    cosmossdk.io/store/[email protected]/commitment/iavl/tree.go:45 +0x28
err> cosmossdk.io/store/v2/commitment.(*CommitStore).WriteChangeset(0x4001212360, 0x0?)
err>    cosmossdk.io/store/[email protected]/commitment/store.go:76 +0x1a0
err> cosmossdk.io/store/v2/root.(*Store).Commit.func1()
err>    cosmossdk.io/store/[email protected]/root/store.go:313 +0x40
err> golang.org/x/sync/errgroup.(*Group).Go.func1()
err>    golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x54
err> created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 118
err>    golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x98

  __      _ _          _ 
 / _|    (_) |        | |
| |_ __ _ _| | ___  __| |
|  _/ _| | | |/ _ \/ _| |
| || (_| | | |  __/ (_| |
|_| \__,_|_|_|\___|\__,_|
FAIL    github.com/cosmos/cosmos-sdk/tests/systemtests  8.422s
FAIL
make[1]: *** [Makefile:8: test] Error 1
make[1]: Leaving directory '/home/julien/projects/cosmos/cosmos-sdk/tests/systemtests'
make: *** [scripts/build/testing.mk:27: test-system] Error 2

@julienrbrt julienrbrt mentioned this issue Dec 9, 2024
Merged
12 tasks
@julienrbrt julienrbrt moved this from 🤸‍♂️ In Progress to 👀 Waiting / In review in Cosmos-SDK Dec 9, 2024
@hieuvubk hieuvubk mentioned this issue Dec 9, 2024
Merged
12 tasks
@mergify mergify bot mentioned this issue Dec 9, 2024
Merged
12 tasks
@mmsqe
Copy link
Contributor

mmsqe commented Dec 10, 2024

I am seeing some system tests being flaky and failing with: It should be investigated as well.

The iavl one seems triggered after this Close, not sure it's related to stopping servers

@mergify mergify bot mentioned this issue Dec 11, 2024
Merged
12 tasks
@julienrbrt julienrbrt mentioned this issue Dec 11, 2024
Merged
12 tasks
@mergify mergify bot mentioned this issue Dec 11, 2024
Merged
12 tasks
@julienrbrt julienrbrt mentioned this issue Dec 11, 2024
Merged
12 tasks
@mergify mergify bot mentioned this issue Dec 12, 2024
Merged
12 tasks
@julienrbrt julienrbrt linked a pull request Dec 12, 2024 that will close this issue
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

@hieuvubk hieuvubk

Labels
C:server/v2 Issues related to server/v2 T: Tests
Projects
Cosmos-SDK
Status: 👀 Waiting / In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(systemtests): fix iavl nil cosmos/cosmos-sdk
3 participants
@mmsqe @julienrbrt @hieuvubk