refactor(config): remove evmAppOptions entirely (#661)

* move tests to remove circular dependency

* remove ante2

* wip: move all config files out of evmd

* wip: add todos

* reset config to fix test

* fix evmd tests by adding resets to the evmappoptions

* remove testutil/config constants

consolidates these constants into one file in /config

* fix eips test

the test was using a duplicate eips multiplier value instead of the global one moved to config

* remove all configs except for genesis from testutil/config and consolidate into /config

* changelogchangelogchangelogchangelogchangelog

* lints

* wip: removing app options (tests failing)

app options is removed from new app creation.

however, we're getting a recovered panic on *restarting* the chain due to prepareproposal running before preblocker:

+0x120\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).PrepareProposal.func1()\n\tgithub.com/cosmos/[email protected]/baseapp/abci.go:433 +0x38\npanic({0x1061c8160?, 0x10912faa0?})\n\truntime/panic.go:783 +0x120\ngithub.com/cosmos/evm/x/vm/types.GetEVMCoinDecimals(...)\n\tgithub.com/cosmos/[email protected]/x/vm/types/denom_config.go:61\ngithub.com/cosmos/evm/x/vm/types.ConvertAmountTo18DecimalsLegacy(...)\n\tgithub.com/cosmos/[email protected]/x/vm/types/scaling.go:17\ngithub.com/cosmos/evm/x/vm/wrappers.FeeMarketWrapper.GetBaseFee({{_, _}}, {{0x10698a810, 0x109225540}, {0x1069b51c0, 0x14001f4c200}, {{0x0, 0x0}, {0x16dc0f689, 0x4}, ...}, ...})\n\tgithub.com/cosmos/[email protected]/x/vm/wrappers/feemarket.go:38 +0x68\ngithub.com/cosmos/evm/x/vm/keeper.Keeper.GetBaseFee({{0x1069b4890, 0x14001eddeb0}, {0x10695e0b0, 0x14003560450}, {0x10695e240, 0x14003560490}, 0x140035637a0, {0x1400189d3e0, 0x14, 0x20}, ...}, ...)\n\tgithub.com/cosmos/[email protected]/x/vm/keeper/keeper.go:355 +0xe4\ngithub.com/cosmos/evm/mempool.(*ExperimentalEVMMempool).getIterators(0x14003cbd180, {0x10698a848?, 0x14002c39c08?}, {0x109225540, 0x0, 0x0})\n\tgithub.com/cosmos/[email protected]/mempool/mempool.go:439 +0x20c\ngithub.com/cosmos/evm/mempool.(*ExperimentalEVMMempool).SelectBy(0x14003cbd180, {0x10698a848?, 0x14002c39c08?}, {0x109225540?, 0x14000085ce8?, 0x104cce034?}, 0x140044cd540)\n\tgithub.com/cosmos/[email protected]/mempool/mempool.go:370 +0xe0\ngithub.com/cosmos/cosmos-sdk/types/mempool.SelectBy({0x10698a848?, 0x14002c39c08?}, {0x10698b108?, 0x14003cbd180?}, {0x109225540?, 0x0?, 0x0?}, 0x140044cd540)\n\tgithub.com/cosmos/[email protected]/types/mempool/mempool.go:58 +0xa0\ngithub.com/cosmos/evm/evmd.NewExampleApp.(*DefaultProposalHandler).PrepareProposalHandler.func3({{0x10698a810, 0x109225540}, {0x1069b51c0, 0x14001f4c200}, {{0x0, 0x0}, {0x16dc0f689, 0x4}, 0xd, {0x3507e5b0, ...}, ...}, ...}, ...)\n\tgithub.com/cosmos/[email protected]/baseapp/abci_utils.go:294 +0x250\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).PrepareProposal(0x14002d32488, 0x140015f42c0)\n\tgithub.com/cosmos/[email protected]/baseapp/abci.go:439

* begin storing coin info in the vm keeper storage

the mempool needed the global variable, but that wasn't set, so we set it in the vm keeper storage and use it from there in the mempool

everything else still uses the global variable, but we now have a foundation to move it over to the state storage

* remove debugging artifact

* artifact removal 2

* fix unit tests

* wip: fix ibc testing

* delete all evmappoptions from tests

* fix ibc precompile integration test balance getters

we were getting the 6 decimal balance when we were operating in 18-balance territory. now that we have a separation in the ibc tests, we should check balances accordingly

* fix all evmd tests

* fix precisebank keeper test

* fix smore tests

* lol

* add upgrade handler

* lints

* changelog

* Fix imports, add upgrade for non-18-decimal chains, and add migration guide

* fix system test

* Update docs/migrations/v0.4.0_to_v0.5.0_UNRELEASED.md

Co-authored-by: Abdul Malek <[email protected]>

* fix monodecorator test

* Remove test* denoms and replace with default*

* extract var

* match vars

* remove chain config from configurator

* undo uint8 change

* comment fixes

* Auto stash before merge of "vlad/remove-app-options" and "origin/main"

* set chain config in vm integ tests

* lint

* fix error on test

* fix denoms for ibc chain

* Revert "fix denoms for ibc chain"

This reverts commit cbbaa44.

* use app options chain id instead of passing param

* lints

* revert make race

---------

Co-authored-by: Abdul Malek <[email protected]>

Author: vladjdk

CHANGELOG.md

@@ -65,6 +65,8 @@
 - [\#477](https://github.com/cosmos/evm/pull/477) Refactor precompile constructors to accept keeper interfaces instead of concrete implementations, breaking the existing `NewPrecompile` function signatures.
 - [\#594](https://github.com/cosmos/evm/pull/594) Remove all usage of x/params
 - [\#577](https://github.com/cosmos/evm/pull/577) Changed the way to create a stateful precompile based on the cmn.Precompile, change `NewPrecompile` to not return error.
+- [\#661](https://github.com/cosmos/evm/pull/661) Removes evmAppOptions from the repository and moves initialization to genesis. Chains must now have a display and denom metadata set for the defined EVM denom in the bank module's metadata.
+
 
 ## v0.4.1
 

ante/evm/fee_checker_test.go

@@ -35,9 +35,24 @@ func TestSDKTxFeeChecker(t *testing.T) {
 	//      without extension option
 	//      london hardfork enableness
 	chainID := uint64(config.EighteenDecimalsChainID)
-	encodingConfig := encoding.MakeConfig(chainID)
-	err := config.EvmAppOptions(chainID)
+	encodingConfig := encoding.MakeConfig(chainID) //nolint:staticcheck // this is used
+
+	configurator := evmtypes.NewEVMConfigurator()
+	configurator.ResetTestConfig()
+	// set global chain config
+	ethCfg := evmtypes.DefaultChainConfig(chainID)
+	if err := evmtypes.SetChainConfig(ethCfg); err != nil {
+		panic(err)
+	}
+	err := configurator.
+		WithExtendedEips(evmtypes.DefaultCosmosEVMActivators).
+		// NOTE: we're using the 18 decimals default for the example chain
+		WithEVMCoinInfo(config.ChainsCoinInfo[chainID]).
+		Configure()
 	require.NoError(t, err)
+	if err != nil {
+		panic(err)
+	}
 
 	evmDenom := evmtypes.GetEVMCoinDenom()
 	minGasPrices := sdk.NewDecCoins(sdk.NewDecCoin(evmDenom, math.NewInt(10)))

ante/evm/mono_decorator.go

@@ -111,8 +111,11 @@ func (md MonoDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, ne
 		Time:       uint64(ctx.BlockTime().Unix()), //nolint:gosec
 		Difficulty: big.NewInt(0),
 	}
+
+	chainConfig := evmtypes.GetEthChainConfig()
+
 	if err := txpool.ValidateTransaction(ethTx, &header, decUtils.Signer, &txpool.ValidationOptions{
-		Config:  evmtypes.GetEthChainConfig(),
+		Config:  chainConfig,
 		Accept:  AcceptedTxType,
 		MaxSize: math.MaxUint64, // tx size is checked in cometbft
 		MinTip:  new(big.Int),

ante/evm/mono_decorator_test.go

@@ -147,7 +147,6 @@ func toMsgSlice(msgs []*evmsdktypes.MsgEthereumTx) []sdk.Msg {
 
 func TestMonoDecorator(t *testing.T) {
 	chainID := uint64(config.EighteenDecimalsChainID)
-	require.NoError(t, config.EvmAppOptions(chainID))
 	cfg := encoding.MakeConfig(chainID)
 
 	testCases := []struct {
@@ -197,6 +196,23 @@ func TestMonoDecorator(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
+			configurator := evmsdktypes.NewEVMConfigurator()
+			configurator.ResetTestConfig()
+			chainConfig := evmsdktypes.DefaultChainConfig(evmsdktypes.DefaultEVMChainID)
+			err := evmsdktypes.SetChainConfig(chainConfig)
+			require.NoError(t, err)
+			coinInfo := evmsdktypes.EvmCoinInfo{
+				Denom:         evmsdktypes.DefaultEVMExtendedDenom,
+				ExtendedDenom: evmsdktypes.DefaultEVMExtendedDenom,
+				DisplayDenom:  evmsdktypes.DefaultEVMDisplayDenom,
+				Decimals:      18,
+			}
+			err = configurator.
+				WithExtendedEips(evmsdktypes.DefaultCosmosEVMActivators).
+				// NOTE: we're using the 18 decimals default for the example chain
+				WithEVMCoinInfo(coinInfo).
+				Configure()
+			require.NoError(t, err)
 			privKey, _ := ethsecp256k1.GenerateKey()
 			keeper, cosmosAddr := setupFundedKeeper(t, privKey)
 			accountKeeper := MockAccountKeeper{FundedAddr: cosmosAddr}