Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application crashes if the chain is stopped #4

Closed
andynog opened this issue Nov 24, 2020 · 5 comments · Fixed by #6
Closed

Application crashes if the chain is stopped #4

andynog opened this issue Nov 24, 2020 · 5 comments · Fixed by #6
Labels
bug Something isn't working

Comments

@andynog
Copy link

andynog commented Nov 24, 2020

Describe the bug

The tui crashes if you stop the chain that is listening to.

To Reproduce
Steps to reproduce the behavior:

  • Start a chain in a terminal windown e.g. $ gaiad start
  • On another terminal run the tool $ gex
  • Go back to the terminal that was running the chain and stop it
  • The tui will show the error below
panic: Get "http://localhost:26657/heal": dial tcp [::1]:26657: connect: connection refused
go routine 55 [running]:
...

Expected behavior

Probably in the routine listening on the port, some error handling could gracefully exit the tool or if possible (maybe more complex), show an error in the Health widget.

Screenshot

gex_error

@toschdev
Copy link
Contributor

@andynog Mind to try this branch #6
Would be great to get your feedback on this

@andynog
Copy link
Author

andynog commented Dec 14, 2020

OK @Tosch110 I will give it a try later today. Thanks!

@andynog
Copy link
Author

andynog commented Dec 14, 2020

Seems to be working now. When I stop the chain doesn't crash anymore just show a red dot, if I start the chain again it can re-connect which is nice. The only thing is that the dashboard lines seems to be a little bit out of order (see image). This is running from a terminal on a Linux machine (Fedora) not sure if it matters but just providing some context.

gex

@toschdev
Copy link
Contributor

Thanks, I will try to replicate and find a solution.

@toschdev toschdev added the bug Something isn't working label Dec 24, 2020
@toschdev
Copy link
Contributor

I'll still merge it, I cannot find a solution as it is without major rewrite. Having a bit dizzy layout, you probably want to restart. Better than a terminal in a bad state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants