Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The name router is ambiguous given its usage in other contexts #101

Closed
Reecepbcups opened this issue Sep 26, 2023 · 0 comments · Fixed by #118
Closed

The name router is ambiguous given its usage in other contexts #101

Reecepbcups opened this issue Sep 26, 2023 · 0 comments · Fixed by #118
Assignees
Labels
packet-forward-middleware Label for items related to the packet forward middleware

Comments

@Reecepbcups
Copy link
Member

From Justin in the previous repo: strangelove-ventures/packet-forward-middleware#10

router is used in a few different contexts across modules/in the SDK so perhaps renaming to ibcrouter would be less confusing

"I think pfm or forward are valid choices! typically when I import the middleware into other repos I end up creating an alias called forward"

"I think a lot of apps already rename the import to packetforward so this might be a good candidate as well"

@Reecepbcups Reecepbcups added the packet-forward-middleware Label for items related to the packet forward middleware label Sep 26, 2023
@Reecepbcups Reecepbcups changed the title PFM: The name router is ambiguous given its usage in other contexts The name router is ambiguous given its usage in other contexts Sep 26, 2023
@Reecepbcups Reecepbcups self-assigned this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packet-forward-middleware Label for items related to the packet forward middleware
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant