Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulfil only necessary interfaces in each module's module.go #7701

Open
4 tasks
DimitrisJim opened this issue Dec 17, 2024 · 1 comment
Open
4 tasks

Fulfil only necessary interfaces in each module's module.go #7701

DimitrisJim opened this issue Dec 17, 2024 · 1 comment
Labels
nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Dec 17, 2024

Raised in #7261 #7261 (comment)

is this solely to fulfil the AppModuleBasic interface we currently assert on line 34? Can't we just fulfil the HasGRPCGateway https://github.com/cosmos/cosmos-sdk/blob/5799c15b90998b1a1474c50695f0d5063af6bd38/types/module/module.go#L52 interface?

From what I understand we can remove the assertion on AppModuleBasic and only use HasGRPCGateway.

I think we should comb through all of the modules to ensure we have the minimum amount of interface assertions needed.

Should be done after #7261 and relevant PRs for it are merged.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@DimitrisJim DimitrisJim added nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces labels Dec 17, 2024
@Sruthi2357
Copy link

Shall I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Development

No branches or pull requests

2 participants