We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module.go
Raised in #7261 #7261 (comment)
is this solely to fulfil the AppModuleBasic interface we currently assert on line 34? Can't we just fulfil the HasGRPCGateway https://github.com/cosmos/cosmos-sdk/blob/5799c15b90998b1a1474c50695f0d5063af6bd38/types/module/module.go#L52 interface?
From what I understand we can remove the assertion on AppModuleBasic and only use HasGRPCGateway. I think we should comb through all of the modules to ensure we have the minimum amount of interface assertions needed.
From what I understand we can remove the assertion on AppModuleBasic and only use HasGRPCGateway.
I think we should comb through all of the modules to ensure we have the minimum amount of interface assertions needed.
Should be done after #7261 and relevant PRs for it are merged.
The text was updated successfully, but these errors were encountered:
Shall I work on this?
Sorry, something went wrong.
No branches or pull requests
Raised in #7261 #7261 (comment)
Should be done after #7261 and relevant PRs for it are merged.
For Admin Use
The text was updated successfully, but these errors were encountered: