[ibc-client-tendermint-types] properly handle fallible conversion between prost Duration
and core Duration
#1376
Labels
A: bug
Admin: something isn't working
Bug Summary
This PR informalsystems/tendermint-rs#1456 makes the conversion between
tendermint-rs
's auto-compiled Google'sDuration
andcore::time::Duration
fallible in both direction.Because of this, our
From<DomainClientState> for ProtoClientState
pattern fails for Tendermint light client state implementations.Details
The below is the current fix for Tendermint light client fields which use
Duration
type.ibc-rs/ibc-clients/ics07-tendermint/types/src/client_state.rs
Lines 323 to 325 in 81625d6
Ideally, the following implementation
ibc-rs/ibc-clients/ics07-tendermint/types/src/client_state.rs
Line 317 in 81625d6
should be refactored to,
with
For this, we need a refactor of
Protobuf
trait intendermint-rs
repo -- which should useTryFrom<Self>
.Version
The text was updated successfully, but these errors were encountered: