From 79ddeafa08787e6cb3e9468c8b3ab491ead52dfa Mon Sep 17 00:00:00 2001 From: ivan-gavran Date: Thu, 22 May 2025 11:46:43 +0200 Subject: [PATCH 1/3] corrected the denom that B is burning before sending back to A --- spec/app/ics-020-fungible-token-transfer/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/app/ics-020-fungible-token-transfer/README.md b/spec/app/ics-020-fungible-token-transfer/README.md index 963896d17..73db65082 100644 --- a/spec/app/ics-020-fungible-token-transfer/README.md +++ b/spec/app/ics-020-fungible-token-transfer/README.md @@ -79,7 +79,7 @@ sequenceDiagram chain C->>chain B: Send transfer packet with vouchers ("transfer/ChannelToB/transfer/ChannelToA/denom") chain B->>chain B: Unlock (unescrow) vouchers ("transfer/ChannelToA/denom") Note over chain B,chain A: B is sink zone: B -> A - chain B->>chain B: Burn vouchers ("transfer/ChannelToB/transfer/ChannelToA/denom") + chain B->>chain B: Burn vouchers ("transfer/channelToA/denom") chain B->>chain A: Send transfer packet with vouchers ("transfer/ChannelToB/transfer/ChannelToA/denom") chain A->>chain A: Unlock (unescrow) vouchers ("transfer/ChannelToA/denom") ``` From c3a1ad75a4ceda4f55a5db66614bf8e00bd5d2bc Mon Sep 17 00:00:00 2001 From: ivan-gavran Date: Thu, 22 May 2025 11:54:04 +0200 Subject: [PATCH 2/3] fixed denoms sent to A and unlocked by A --- spec/app/ics-020-fungible-token-transfer/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/app/ics-020-fungible-token-transfer/README.md b/spec/app/ics-020-fungible-token-transfer/README.md index 73db65082..b35ebe927 100644 --- a/spec/app/ics-020-fungible-token-transfer/README.md +++ b/spec/app/ics-020-fungible-token-transfer/README.md @@ -80,8 +80,8 @@ sequenceDiagram chain B->>chain B: Unlock (unescrow) vouchers ("transfer/ChannelToA/denom") Note over chain B,chain A: B is sink zone: B -> A chain B->>chain B: Burn vouchers ("transfer/channelToA/denom") - chain B->>chain A: Send transfer packet with vouchers ("transfer/ChannelToB/transfer/ChannelToA/denom") - chain A->>chain A: Unlock (unescrow) vouchers ("transfer/ChannelToA/denom") + chain B->>chain A: Send transfer packet with vouchers ("transfer/ChannelToA/denom") + chain A->>chain A: Unlock (unescrow) vouchers ("denom") ``` The acknowledgement data type describes whether the transfer succeeded or failed, and the reason for failure (if any). From df2f1f282e7c84cbe23f81258dd01beb40fa6916 Mon Sep 17 00:00:00 2001 From: Ivan Gavran Date: Tue, 27 May 2025 13:47:34 +0200 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Christoph Otter --- spec/app/ics-020-fungible-token-transfer/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/app/ics-020-fungible-token-transfer/README.md b/spec/app/ics-020-fungible-token-transfer/README.md index b35ebe927..768d5ea0b 100644 --- a/spec/app/ics-020-fungible-token-transfer/README.md +++ b/spec/app/ics-020-fungible-token-transfer/README.md @@ -79,9 +79,9 @@ sequenceDiagram chain C->>chain B: Send transfer packet with vouchers ("transfer/ChannelToB/transfer/ChannelToA/denom") chain B->>chain B: Unlock (unescrow) vouchers ("transfer/ChannelToA/denom") Note over chain B,chain A: B is sink zone: B -> A - chain B->>chain B: Burn vouchers ("transfer/channelToA/denom") + chain B->>chain B: Burn vouchers ("transfer/ChannelToA/denom") chain B->>chain A: Send transfer packet with vouchers ("transfer/ChannelToA/denom") - chain A->>chain A: Unlock (unescrow) vouchers ("denom") + chain A->>chain A: Unlock (unescrow) tokens ("denom") ``` The acknowledgement data type describes whether the transfer succeeded or failed, and the reason for failure (if any).