Skip to content

Commit

Permalink
fix(client): write unbonding period advisory to stderr instead of std…
Browse files Browse the repository at this point in the history
…out (#1921)

* fix(client): write unbonding period advisory to stderr instead of stdout

* Add changelog for unbonding period advisory

---------

Co-authored-by: Philip Offtermatt <[email protected]>
  • Loading branch information
chris-ricketts and p-offtermatt committed May 27, 2024
1 parent 16ee6a2 commit 3132f64
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .changelog/unreleased/bug-fixes/1921-write-stderr.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Write unbonding period advisory to stderr instead of stdout
([\#1921](https://github.com/cosmos/interchain-security/pull/1921))
3 changes: 2 additions & 1 deletion x/ccv/provider/client/proposal_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,8 @@ func CheckPropUnbondingPeriod(clientCtx client.Context, propUnbondingPeriod time
providerUnbondingTime := res.Params.UnbondingTime

if providerUnbondingTime < propUnbondingPeriod {
fmt.Printf(
fmt.Fprintf(
os.Stderr,
`consumer unbonding period is advised to be smaller than provider unbonding period, but is longer.
This is not a security risk, but will effectively lengthen the unbonding period on the provider.
consumer unbonding: %s
Expand Down

0 comments on commit 3132f64

Please sign in to comment.