From 3132f64ae49be052475be0c87ebe9c20ef939f1f Mon Sep 17 00:00:00 2001 From: Chris Ricketts <6156768+chris-ricketts@users.noreply.github.com> Date: Mon, 27 May 2024 15:08:55 +0100 Subject: [PATCH] fix(client): write unbonding period advisory to stderr instead of stdout (#1921) * fix(client): write unbonding period advisory to stderr instead of stdout * Add changelog for unbonding period advisory --------- Co-authored-by: Philip Offtermatt --- .changelog/unreleased/bug-fixes/1921-write-stderr.md | 2 ++ x/ccv/provider/client/proposal_handler.go | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 .changelog/unreleased/bug-fixes/1921-write-stderr.md diff --git a/.changelog/unreleased/bug-fixes/1921-write-stderr.md b/.changelog/unreleased/bug-fixes/1921-write-stderr.md new file mode 100644 index 0000000000..665ef78024 --- /dev/null +++ b/.changelog/unreleased/bug-fixes/1921-write-stderr.md @@ -0,0 +1,2 @@ +- Write unbonding period advisory to stderr instead of stdout + ([\#1921](https://github.com/cosmos/interchain-security/pull/1921)) \ No newline at end of file diff --git a/x/ccv/provider/client/proposal_handler.go b/x/ccv/provider/client/proposal_handler.go index bb88276393..022d131e4d 100644 --- a/x/ccv/provider/client/proposal_handler.go +++ b/x/ccv/provider/client/proposal_handler.go @@ -363,7 +363,8 @@ func CheckPropUnbondingPeriod(clientCtx client.Context, propUnbondingPeriod time providerUnbondingTime := res.Params.UnbondingTime if providerUnbondingTime < propUnbondingPeriod { - fmt.Printf( + fmt.Fprintf( + os.Stderr, `consumer unbonding period is advised to be smaller than provider unbonding period, but is longer. This is not a security risk, but will effectively lengthen the unbonding period on the provider. consumer unbonding: %s