From 849b1c8345b0fdbf7a982b6d6efab9e41b60d1e1 Mon Sep 17 00:00:00 2001 From: insumity Date: Thu, 1 Feb 2024 17:36:52 +0100 Subject: [PATCH] docs: tiny ADR fix (#1618) nit fix; remove fraction Co-authored-by: insumity --- docs/docs/adrs/adr-015-partial-set-security.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/docs/adrs/adr-015-partial-set-security.md b/docs/docs/adrs/adr-015-partial-set-security.md index e15a888849..3a6ac43f12 100644 --- a/docs/docs/adrs/adr-015-partial-set-security.md +++ b/docs/docs/adrs/adr-015-partial-set-security.md @@ -56,18 +56,18 @@ In a future version of PSS, we intend to introduce a `ConsumerModificationPropos We augment the provider module’s state to keep track of the `top_N` value for each consumer chain. The key to store this information would be: ``` -topNFractionBytePrefix | len(chainID) | chainID +topNBytePrefix | len(chainID) | chainID ``` To create the above key, we can use [`ChainIdWithLenKey`](https://github.com/cosmos/interchain-security/blob/v4.0.0/x/ccv/provider/types/keys.go#L418). Then in the [keeper](https://github.com/cosmos/interchain-security/blob/v4.0.0/x/ccv/provider/keeper/keeper.go) we introduce methods as follows: ```golang -func (k Keeper) SetTopNFraction(ctx sdk.Context, chainID string, topNFraction string) +func (k Keeper) SetTopN(ctx sdk.Context, chainID string, topN uint32) func (k Keeper) IsTopN(ctx sdk.Context, chainID string) bool func (k Keeper) IsOptIn(ctx sdk.Context, chainID string) bool // returns the N if Top N chain, otherwise an error -func (k Keeper) GetTopNFraction(ctx sdk.Context, chainID string) (Dec, error) +func (k Keeper) GetTopN(ctx sdk.Context, chainID string) (uint32, error) ``` We also extend the `interchain-security-pd query provider list-consumer-chains` query to return information on whether a consumer chain is an Opt In or a Top N chain and with what N.