From adeb72bb9e770eec59a223f62d1082206c214d47 Mon Sep 17 00:00:00 2001 From: Bernd Mueller Date: Fri, 13 Sep 2024 15:12:30 +0200 Subject: [PATCH] addressed comments --- tests/e2e/steps_permissionless_ics.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/e2e/steps_permissionless_ics.go b/tests/e2e/steps_permissionless_ics.go index 065500f1e5..4ddfa85e6e 100644 --- a/tests/e2e/steps_permissionless_ics.go +++ b/tests/e2e/steps_permissionless_ics.go @@ -55,7 +55,7 @@ func stepsPermissionlessICS() []Step { }, State: State{ ChainID("provi"): e2e.ChainState{ - ConsumerChains: &map[ChainID]bool{"cons2": true}, // Consumer chain "consu1" is now removed + ConsumerChains: &map[ChainID]bool{"cons2": true}, }, }, }, @@ -167,7 +167,7 @@ func stepsPermissionlessICS() []Step { ChainID("provi"): e2e.ChainState{ HasToValidate: &map[ValidatorID][]ChainID{ ValidatorID("alice"): {"cons1"}, - ValidatorID("bob"): {"cons1"}, // bob is still a validator on consu chain + ValidatorID("bob"): {"cons1"}, // bob is still a validator on cons1 chain ValidatorID("carol"): {}, }, }, @@ -185,9 +185,13 @@ func stepsPermissionlessICS() []Step { State: State{ ChainID("provi"): e2e.ChainState{ ConsumerChains: &map[ChainID]bool{"cons2": true}, // Consumer chain "cons1" is now removed + // Note: current behavior is that the chain is enqueued for deletion and will be triggered + // when unbonding-period has passed. + // I't is still reported as a chain to be validated until it's finally deleted. + // This behaviour is currently discussed and might change. HasToValidate: &map[ValidatorID][]ChainID{ ValidatorID("alice"): {"cons1"}, - ValidatorID("bob"): {"cons1"}, // bob is still a validator on consu chain + ValidatorID("bob"): {"cons1"}, ValidatorID("carol"): {}, }, },