From f9344e22d1737a86cc300092d46606af87a68ded Mon Sep 17 00:00:00 2001
From: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
Date: Mon, 8 Apr 2024 16:28:31 +0200
Subject: [PATCH] test: Expand PSS e2e test to include slashing (#1752)

* Expand test to include slashing

* Add back existing steps

* Add downtime to top N test

* Fix nits
---
 tests/e2e/steps_partial_set_security.go | 396 +++++++++++++++++++++++-
 1 file changed, 394 insertions(+), 2 deletions(-)

diff --git a/tests/e2e/steps_partial_set_security.go b/tests/e2e/steps_partial_set_security.go
index b9536caa0c..751a710499 100644
--- a/tests/e2e/steps_partial_set_security.go
+++ b/tests/e2e/steps_partial_set_security.go
@@ -225,7 +225,7 @@ func stepsOptInChain() []Step {
 				ChainID("consu"): ChainState{
 					ValPowers: &map[ValidatorID]uint{
 						ValidatorID("alice"): 100,
-						// "bob" has not yet been opted in from the consumer chain because the VSCPacket has not yet been relayed
+						// "bob" has not yet been opted in to the consumer chain because the VSCPacket has not yet been relayed
 						ValidatorID("bob"):   0,
 						ValidatorID("carol"): 300,
 					},
@@ -243,7 +243,190 @@ func stepsOptInChain() []Step {
 				ChainID("consu"): ChainState{
 					ValPowers: &map[ValidatorID]uint{
 						ValidatorID("alice"): 100,
-						// bob has now opted in
+						// bob is in power on the consumer
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+			},
+		},
+		{
+			// DowntimeSlash for alice on consumer
+			Action: DowntimeSlashAction{
+				Chain:     ChainID("consu"),
+				Validator: ValidatorID("alice"),
+			},
+			// powers are not affected yet on either chain
+			State: State{
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 100,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 100,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+			},
+		},
+		{
+			// relay the slash packet
+			Action: RelayPacketsAction{
+				ChainA:  ChainID("consu"),
+				ChainB:  ChainID("provi"),
+				Port:    "consumer",
+				Channel: 0,
+			},
+			// alice's power is reduced on the provider
+			State: State{
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+			},
+		},
+		{
+			// relay the VSCPacket that contains the slashed power for alice
+			Action: RelayPacketsAction{
+				ChainA:  ChainID("consu"),
+				ChainB:  ChainID("provi"),
+				Port:    "consumer",
+				Channel: 0,
+			},
+			// alice's power is reduced on the provider
+			State: State{
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						// alice should definitely not be in power on the consumer
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+			},
+		},
+		{
+			// unjail alice
+			Action: UnjailValidatorAction{
+				Provider:  ChainID("provi"),
+				Validator: ValidatorID("alice"),
+			},
+			// alices power is restored on the provider
+			State: State{
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 100,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+				// still 0 power on the consumer
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+			},
+		},
+		{
+			// relay the VSCPacket that puts alice back into power on the consumer
+			Action: RelayPacketsAction{
+				ChainA:  ChainID("provi"),
+				ChainB:  ChainID("consu"),
+				Port:    "provider",
+				Channel: 0,
+			},
+			// alice's power is restored on the consumer
+			State: State{
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 100,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+			},
+		},
+		{
+			// slash alice for downtime again
+			Action: DowntimeSlashAction{
+				Chain:     ChainID("consu"),
+				Validator: ValidatorID("alice"),
+			},
+			// alice's power is not yet reduced, the packet needs to be relayed
+			State: State{
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 100,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 100,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+			},
+		},
+		{
+			// relay the slash packet
+			Action: RelayPacketsAction{
+				ChainA:  ChainID("consu"),
+				ChainB:  ChainID("provi"),
+				Port:    "consumer",
+				Channel: 0,
+			},
+			// alice's power is reduced on the provider
+			State: State{
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+			},
+		},
+		{
+			// relay the VSCPacket that contains the slashed power for alice
+			Action: RelayPacketsAction{
+				ChainA:  ChainID("consu"),
+				ChainB:  ChainID("provi"),
+				Port:    "consumer",
+				Channel: 0,
+			},
+			// alice's power is reduced on the consumer
+			State: State{
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   200,
+						ValidatorID("carol"): 300,
+					},
+				},
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
 						ValidatorID("bob"):   200,
 						ValidatorID("carol"): 300,
 					},
@@ -476,6 +659,215 @@ func stepsTopNChain() []Step {
 				},
 			},
 		},
+		// opt alice back in
+		{
+			Action: OptInAction{
+				Chain:     ChainID("consu"),
+				Validator: ValidatorID("alice"),
+			},
+			State: State{},
+		},
+		{
+			Action: RelayPacketsAction{
+				ChainA:  ChainID("provi"),
+				ChainB:  ChainID("consu"),
+				Port:    "provider",
+				Channel: 0,
+			},
+			State: State{
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						// "alice" has now opted in
+						ValidatorID("alice"): 200,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+			},
+		},
+		{
+			// DowntimeSlash for alice on consumer
+			Action: DowntimeSlashAction{
+				Chain:     ChainID("consu"),
+				Validator: ValidatorID("alice"),
+			},
+			// powers are not affected yet on either chain
+			State: State{
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 200,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 200,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+			},
+		},
+		{
+			// relay the slash packet
+			Action: RelayPacketsAction{
+				ChainA:  ChainID("consu"),
+				ChainB:  ChainID("provi"),
+				Port:    "consumer",
+				Channel: 0,
+			},
+			// alice's power is reduced on the provider
+			State: State{
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+			},
+		},
+		{
+			// relay the VSCPacket that contains the slashed power for alice
+			Action: RelayPacketsAction{
+				ChainA:  ChainID("consu"),
+				ChainB:  ChainID("provi"),
+				Port:    "consumer",
+				Channel: 0,
+			},
+			// alice's power is reduced on the provider
+			State: State{
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						// alice should definitely not be in power on the consumer
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+			},
+		},
+		{
+			// unjail alice
+			Action: UnjailValidatorAction{
+				Provider:  ChainID("provi"),
+				Validator: ValidatorID("alice"),
+			},
+			// alices power is restored on the provider
+			State: State{
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 200,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+				// still 0 power on the consumer
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+			},
+		},
+		{
+			// relay the VSCPacket that puts alice back into power on the consumer
+			Action: RelayPacketsAction{
+				ChainA:  ChainID("provi"),
+				ChainB:  ChainID("consu"),
+				Port:    "provider",
+				Channel: 0,
+			},
+			// alice's power is restored on the consumer
+			State: State{
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 200,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+			},
+		},
+		{
+			// slash alice for downtime again
+			Action: DowntimeSlashAction{
+				Chain:     ChainID("consu"),
+				Validator: ValidatorID("alice"),
+			},
+			// alice's power is not yet reduced, the packet needs to be relayed
+			State: State{
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 200,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 200,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+			},
+		},
+		{
+			// relay the slash packet
+			Action: RelayPacketsAction{
+				ChainA:  ChainID("consu"),
+				ChainB:  ChainID("provi"),
+				Port:    "consumer",
+				Channel: 0,
+			},
+			// alice's power is reduced on the provider
+			State: State{
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+			},
+		},
+		{
+			// relay the VSCPacket that contains the slashed power for alice
+			Action: RelayPacketsAction{
+				ChainA:  ChainID("consu"),
+				ChainB:  ChainID("provi"),
+				Port:    "consumer",
+				Channel: 0,
+			},
+			// alice's power is reduced on the consumer
+			State: State{
+				ChainID("consu"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+				ChainID("provi"): ChainState{
+					ValPowers: &map[ValidatorID]uint{
+						ValidatorID("alice"): 0,
+						ValidatorID("bob"):   300,
+						ValidatorID("carol"): 500,
+					},
+				},
+			},
+		},
 	}
 
 	return s