Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The API for submitting the equivocation proposal has a lot of defects #1195

Closed
mpoke opened this issue Aug 10, 2023 · 2 comments
Closed

The API for submitting the equivocation proposal has a lot of defects #1195

mpoke opened this issue Aug 10, 2023 · 2 comments
Labels
good first issue Good for newcomers scope: UI Addressing UX changes and improvements to user interface

Comments

@mpoke
Copy link
Contributor

mpoke commented Aug 10, 2023

Problem

This issue is based on the feedback from @zmanian on https://www.mintscan.io/cosmos/proposals/818

Closing criteria

The following concerns are addressed.

Problem details

  • The slashlog isn't queryable. The equivocation packet being received is only visible on the log provider chain. That's hard to access.
  • The equivocation is queryable on the consumer chain. You have equivocation in the consensus address of the consumer chain validator. You need to submit the EquivocationProposal with consensus address of the provider chain. There isn't an obvious way to that reverse look up.
  • The validator can change their consumer key after the slashing event so you need an archive node to look this up.
@mpoke mpoke added the scope: UI Addressing UX changes and improvements to user interface label Aug 10, 2023
@mpoke mpoke added this to Cosmos Hub Aug 10, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Aug 10, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Aug 10, 2023
@MSalopek
Copy link
Contributor

Related:
#741

@mpoke mpoke added the good first issue Good for newcomers label Aug 14, 2023
@mpoke
Copy link
Contributor Author

mpoke commented Sep 14, 2023

Closing since #732 will make this a non-issue.

@mpoke mpoke closed this as completed Sep 14, 2023
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Sep 14, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: UI Addressing UX changes and improvements to user interface
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants