Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup x/ccv/types #1213

Closed
shaspitz opened this issue Aug 18, 2023 · 1 comment · Fixed by #1350
Closed

Cleanup x/ccv/types #1213

shaspitz opened this issue Aug 18, 2023 · 1 comment · Fixed by #1350
Assignees
Labels
good first issue Good for newcomers S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) type: refactoring Code refactoring

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Aug 18, 2023

Problem

#1071 has helped illuminate opportunities for cleanup of x/ccv/types. They will be outlined below.

Closing criteria

  • Remove unreferenced vars and funcs in x/ccv/codec.go.
  • in x/ccv/errors.go, move errors specific to only consumer/provider to their appropriate errors.go file.
  • Ditto for events.go
  • Split out expected_keepers.go to live in the provider/consumer modules separately, this is best practice for sdk modules.
  • Vaguely named consumer structs #1206

Problem details

@shaspitz shaspitz added status: waiting-triage This issue/PR has not yet been triaged by the team. good first issue Good for newcomers labels Aug 18, 2023
@mpoke mpoke added this to Cosmos Hub Aug 21, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Aug 21, 2023
@mpoke mpoke added type: refactoring Code refactoring and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Aug 21, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Aug 21, 2023
@mpoke mpoke added the S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) label Sep 14, 2023
@bermuell bermuell self-assigned this Sep 25, 2023
@MSalopek
Copy link
Contributor

MSalopek commented Oct 10, 2023

Split out expected_keepers.go to live in the provider/consumer modules separately, this is best practice for sdk modules.

This should be it's own separate issue. Changing it now will break upstream work on upgrading versions etc.

@bermuell bermuell moved this from 📥 F2: Todo to 🏗 F3: InProgress in Cosmos Hub Oct 11, 2023
@bermuell bermuell moved this from 🏗 F3: InProgress to 👀 F3: InReview in Cosmos Hub Oct 11, 2023
@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Oct 12, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) type: refactoring Code refactoring
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants