Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate releasing/semver for provider and consumer #1216

Closed
Tracked by #1039
shaspitz opened this issue Aug 18, 2023 · 5 comments · Fixed by #1217
Closed
Tracked by #1039

Separate releasing/semver for provider and consumer #1216

shaspitz opened this issue Aug 18, 2023 · 5 comments · Fixed by #1217
Assignees

Comments

@shaspitz
Copy link
Contributor

Problem

We're going to ditch the idea of "go.mod split" in favor of keeping one go.mod and separating releasing/semver for consumer and provider with tags. See #801 (comment)

Closing criteria

  • New releasing procedure is documented
  • PR template updated

Problem details

@shaspitz shaspitz added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Aug 18, 2023
@shaspitz shaspitz self-assigned this Aug 18, 2023
@shaspitz shaspitz moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Aug 18, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Aug 18, 2023
@shaspitz shaspitz removed the status: waiting-triage This issue/PR has not yet been triaged by the team. label Aug 18, 2023
@shaspitz
Copy link
Contributor Author

Just tried some things out and it'd be better to slightly alter the release paradigm to look like vX.Y.Z-provider and vX.Y.Z-consumer, instead of prefixing the semver number, this is more consistent with tags we've released in the past, and I just confirmed both formats are importable by other repos

@shaspitz shaspitz mentioned this issue Aug 18, 2023
8 tasks
@p-offtermatt
Copy link
Contributor

p-offtermatt commented Aug 21, 2023

I might have missed it, but should there also be an ADR for this to supercede #897? It might be worth it to get a better summary of benefits/costs associated with this, and to get the context collected in one place.

@mpoke mpoke moved this from 📥 Todo to 👀 In review in Cosmos Hub Aug 21, 2023
@shaspitz
Copy link
Contributor Author

I can convert the comment mentioned in this issue to an ADR if you'd like? This topic got to a point that it has been talked about all year (too much discussion imo) and never solved, so I skipped ADR :)

@p-offtermatt
Copy link
Contributor

I think that comment could almost verbatim become an ADR, yes!

@shaspitz
Copy link
Contributor Author

shaspitz commented Aug 22, 2023

I think that comment could almost verbatim become an ADR, yes!

Sounds good 👍 #1229

@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Sep 5, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants