Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the e2e framework to take traces as an input #1240

Closed
Tracked by #2435 ...
p-offtermatt opened this issue Aug 25, 2023 · 1 comment · Fixed by #1313, #1314 or #1318
Closed
Tracked by #2435 ...

Modify the e2e framework to take traces as an input #1240

p-offtermatt opened this issue Aug 25, 2023 · 1 comment · Fixed by #1313, #1314 or #1318
Assignees
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.

Comments

@p-offtermatt
Copy link
Contributor

p-offtermatt commented Aug 25, 2023

The e2e framework should have a way to read and execute test traces given in a file.
Currently, the only way to write test traces is as go code, and this is messy to generate e.g. in MBT.
The proposition is to use a basic JSON format, but the exact format is not particularly important, as long as it is reasonable.
Noone depends on this (yet), and we can always (and will probably need to, due to different abstraction levels) write shims/drivers to go from other formats to our format.

See https://github.com/cosmos/interchain-security/tree/ph/875-use-traces-in-tests

Closing Criterion

It is possible to run the e2e tests using traces from files as inputs.

@p-offtermatt p-offtermatt self-assigned this Aug 25, 2023
@p-offtermatt p-offtermatt linked a pull request Aug 25, 2023 that will close this issue
@p-offtermatt p-offtermatt added the scope: testing Code review, testing, making sure the code is following the specification. label Aug 25, 2023
@p-offtermatt p-offtermatt moved this to 📥 Todo in Cosmos Hub Aug 25, 2023
@p-offtermatt p-offtermatt changed the title Modify the e2e framework to take traces as an input (see https://github.com/cosmos/interchain-security/tree/ph/875-use-traces-in-tests) Modify the e2e framework to take traces as an input Aug 25, 2023
@p-offtermatt p-offtermatt moved this from 📥 F2: Todo to 🏗 F3: InProgress in Cosmos Hub Sep 6, 2023
@p-offtermatt p-offtermatt added the S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth label Sep 8, 2023
@p-offtermatt p-offtermatt moved this from 🏗 F3: InProgress to 🛑 F3: OnHold in Cosmos Hub Sep 11, 2023
@p-offtermatt p-offtermatt moved this from 🛑 F3: OnHold to 🏗 F3: InProgress in Cosmos Hub Sep 11, 2023
@p-offtermatt p-offtermatt moved this from 🏗 F3: InProgress to 👀 F3: InReview in Cosmos Hub Sep 15, 2023
@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Sep 19, 2023
@p-offtermatt p-offtermatt reopened this Sep 20, 2023
@github-project-automation github-project-automation bot moved this from 👍 F4: Assessment to 🩹 F1: Triage in Cosmos Hub Sep 20, 2023
@p-offtermatt
Copy link
Contributor Author

Reopening, since only part of this was merged so far

@mpoke mpoke moved this from 🩹 F1: Triage to 👀 F3: InReview in Cosmos Hub Sep 21, 2023
@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Sep 25, 2023
@p-offtermatt p-offtermatt moved this from 👍 F4: Assessment to 👀 F3: InReview in Cosmos Hub Sep 25, 2023
@p-offtermatt p-offtermatt linked a pull request Sep 25, 2023 that will close this issue
8 tasks
@p-offtermatt p-offtermatt moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Sep 27, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.
Projects
Status: ✅ Done
1 participant