Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double voting evidence handler only works with consumer pubkeys #1253

Closed
5 tasks
sainoe opened this issue Sep 1, 2023 · 0 comments · Fixed by #1254
Closed
5 tasks

Double voting evidence handler only works with consumer pubkeys #1253

sainoe opened this issue Sep 1, 2023 · 0 comments · Fixed by #1254
Assignees
@sainoe
Labels
S: NewThings Work towards your business objectives with new products, features, or integrations type: bug Issues that need priority attention -- something isn't working

Comments

@sainoe
Copy link
Contributor

sainoe commented Sep 1, 2023 •
edited
Loading

Summary of Bug

Currently, the ICS double voting evidence handler uses the GetValidatorConsumerPubKey method to retrieve the public keys used by validators on consumer chains. But this method only returns validator public keys assigned to a consumer chain. This causes the MsgSubmitConsumerDoubleVoting messages to fail unexpectedly when validators use the same public key on both the consumer and provider chains.

This bug was found through E2E testing and is fixed in PR #1254, which is required to update the E2E tests.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@sainoe sainoe added the type: bug Issues that need priority attention -- something isn't working label Sep 1, 2023
@sainoe sainoe self-assigned this Sep 1, 2023
@sainoe sainoe added this to Cosmos Hub Sep 1, 2023
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Sep 1, 2023
@sainoe sainoe mentioned this issue Sep 1, 2023
Merged
20 tasks
@sainoe sainoe linked a pull request Sep 1, 2023 that will close this issue
fix: make HandleConsumerDoubleVoting works with provider pubkeys #1254
Merged
20 tasks
@sainoe sainoe added the S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) label Sep 1, 2023
@sainoe sainoe moved this from 🩹 F1: Triage to 👀 F3: InReview in Cosmos Hub Sep 1, 2023
@mpoke mpoke added S: NewThings Work towards your business objectives with new products, features, or integrations and removed S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) labels Sep 4, 2023
@mpoke mpoke closed this as completed Sep 5, 2023
@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Sep 5, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainoe sainoe

Labels
S: NewThings Work towards your business objectives with new products, features, or integrations type: bug Issues that need priority attention -- something isn't working
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make HandleConsumerDoubleVoting works with provider pubkeys cosmos/interchain-security
2 participants
@mpoke @sainoe