Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify signatures in misbehaviour handling #1421

Closed
sainoe opened this issue Nov 13, 2023 · 0 comments · Fixed by #1422
Closed

Verify signatures in misbehaviour handling #1421

sainoe opened this issue Nov 13, 2023 · 0 comments · Fixed by #1422
Assignees
@sainoe
Labels
status: waiting-triage This issue/PR has not yet been triaged by the team.

Comments

@sainoe
Copy link
Contributor

sainoe commented Nov 13, 2023 •
edited
Loading

Problem

It appears that VerifyCommitLightTrusting verifies that a TrustLevel signed a given header but does not necessarily verify all validators signature. Therefore, the fix in #1404 is insufficient to prevent an attacker from slashing innocent validators.

Closing criteria

Verify all byzantine validator's signatures in misbehaviour handling.

Problem details.
@sainoe sainoe added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Nov 13, 2023
@sainoe sainoe self-assigned this Nov 13, 2023
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Nov 13, 2023
@sainoe sainoe changed the title Verify all byzantine validator signatures in misbehaviour handling Verify signatures in misbehaviour handling Nov 13, 2023
@sainoe sainoe mentioned this issue Nov 13, 2023
Merged
21 tasks
@sainoe sainoe linked a pull request Nov 13, 2023 that will close this issue
fix!: verify the signatures of byzantine validators in misbehaviour handling #1422
Merged
21 tasks
@mpoke mpoke closed this as completed Nov 14, 2023
@github-project-automation github-project-automation bot moved this from 🩹 F1: Triage to 👍 F4: Assessment in Cosmos Hub Nov 14, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainoe sainoe

Labels
status: waiting-triage This issue/PR has not yet been triaged by the team.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
2 participants
@mpoke @sainoe