Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial Set Security: Introduce integration & E2E tests #1630

Closed
Tracked by #853
insumity opened this issue Feb 8, 2024 · 1 comment · Fixed by #1737 or #1752
Closed
Tracked by #853

Partial Set Security: Introduce integration & E2E tests #1630

insumity opened this issue Feb 8, 2024 · 1 comment · Fixed by #1737 or #1752
Assignees
@insumity
Labels
S: NewThings Work towards your business objectives with new products, features, or integrations

Comments

@insumity
Copy link
Contributor

insumity commented Feb 8, 2024

Problem

Introduce E2E tests for things like: i) sending MsgOptIn, etc. messages, ii) voting YES on a ConsumerAdditionProposal, iii) sending partial sets to the consumer chains, etc.
If easier and we can test the same, for simplicity aim for integration tests instead.

Closing criteria

Working E2E tests that capture the essence of PSS.
@insumity insumity added C:x/provider Assigned automatically by the PR labeler S: NewThings Work towards your business objectives with new products, features, or integrations labels Feb 8, 2024
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Feb 8, 2024
@insumity insumity mentioned this issue Feb 8, 2024
Closed
@insumity insumity moved this from 🩹 F1: Triage to 🏗 F3: InProgress in Cosmos Hub Mar 21, 2024
@mpoke mpoke removed the C:x/provider Assigned automatically by the PR labeler label Mar 22, 2024
@insumity insumity moved this from 🏗 F3: InProgress to 👀 F3: InReview in Cosmos Hub Mar 28, 2024
@insumity insumity self-assigned this Mar 28, 2024
@insumity insumity mentioned this issue Mar 28, 2024
Merged
21 tasks
@insumity insumity linked a pull request Mar 28, 2024 that will close this issue
test: add partial-set-security E2E tests #1737
Merged
21 tasks
@insumity insumity moved this from 👀 F3: InReview to 🏗 F3: InProgress in Cosmos Hub Mar 28, 2024
@insumity insumity moved this from 🏗 F3: InProgress to 👀 F3: InReview in Cosmos Hub Mar 28, 2024
@insumity insumity moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Apr 4, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Apr 4, 2024
@insumity insumity linked a pull request Apr 11, 2024 that will close this issue
test: Expand PSS e2e test to include slashing #1752
Merged
8 tasks
@insumity
Copy link
Contributor Author

We have written E2E (e.g,. #1737, #1752) and integration tests for PSS (#1687).
However, leaving this issue open for now because we might want to add more (e.g, for #1781).

@mpoke mpoke closed this as completed Apr 11, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 👍 F4: Assessment in Cosmos Hub Apr 11, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@insumity insumity

Labels
S: NewThings Work towards your business objectives with new products, features, or integrations
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
2 participants
@insumity @mpoke