Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Tests from Integration Tests #2306

Open
kirdatatjana opened this issue Sep 23, 2024 · 0 comments
Open

Moving Tests from Integration Tests #2306

kirdatatjana opened this issue Sep 23, 2024 · 0 comments
Labels
scope: testing Code review, testing, making sure the code is following the specification. type: refactoring Code refactoring

Comments

@kirdatatjana
Copy link
Contributor

Problem

Moving Tests from Integration Tests:

  • TestQueueAndSendSlashPacket doesn't need to be an integration test because it concentrates on the behavior of the QueueSlashPacket and GetPendingPackets methods without relying on the general state or interactions with other components.
  • TestOnRecvSlashPacketErrors doesn't need to be an integration test because it checks the behavior of the OnRecvSlashPacket method independently of the general state or interactions with other components.

Closing criteria

Remove tests from integration and move them to unit tests if necessary.

@kirdatatjana kirdatatjana added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Sep 23, 2024
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Sep 23, 2024
@p-offtermatt p-offtermatt added scope: testing Code review, testing, making sure the code is following the specification. and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Sep 23, 2024
@p-offtermatt p-offtermatt moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Sep 23, 2024
@p-offtermatt p-offtermatt added the type: refactoring Code refactoring label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: testing Code review, testing, making sure the code is following the specification. type: refactoring Code refactoring
Projects
Status: 📥 F2: Todo
Development

No branches or pull requests

2 participants