chore: proto check that works #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
MSalopek
approved these changes
Jun 22, 2023
mpoke
pushed a commit
that referenced
this pull request
Jun 22, 2023
* fix: update proto build tooling * fix: re-enable make proto-check in CI * chore: proto check that works (#1063) * wip * works * comments --------- Co-authored-by: Shawn <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
* fix: update proto build tooling * fix: re-enable make proto-check in CI * chore: proto check that works (#1063) * wip * works * comments --------- Co-authored-by: Shawn <[email protected]> (cherry picked from commit acc494f) # Conflicts: # .github/workflows/automated-tests.yml
MSalopek
added a commit
that referenced
this pull request
Jun 22, 2023
) (#1067) * fix: re-enable make proto-check and update proto options (#1060) * fix: update proto build tooling * fix: re-enable make proto-check in CI * chore: proto check that works (#1063) * wip * works * comments --------- Co-authored-by: Shawn <[email protected]> (cherry picked from commit acc494f) # Conflicts: # .github/workflows/automated-tests.yml * chore: resolve conflicts --------- Co-authored-by: MSalopek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds on #1060 to enable the
make proto-checktest to actually work with the new way of generating protos. This approach is slightly worse, but it works and it's not worth spending anymore time on fixingmake proto-checkAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...