chore: Fix and enable CometMock in e2e tests #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-offtermatt
changed the title
p-offtermatt
changed the base branch from
main
to
masa/1178-happy-path-cleanup-continued
…cometmock-integration-for-47-upgrade
p-offtermatt
merged commit 5ec3365
into
masa/1178-happy-path-cleanup-continued
4 checks passed
MSalopek
pushed a commit
that referenced
this pull request
Aug 9, 2023
* Add make time.sleep WaitTime and wait block after waiting time * Uncomment verbose error check * Fix spacing * Make format * Add make target for CometMock e2e tests * Add CometMock job to automated tests
MSalopek
added a commit
that referenced
this pull request
Aug 9, 2023
* test: reduce number of happyPath steps * test: reduce number of happyPath steps * test: update steps after opt-out * test: update steps and fix lint * tests: add cometmock tests * chore: Fix and enable CometMock in e2e tests (#1184) * Add make time.sleep WaitTime and wait block after waiting time * Uncomment verbose error check * Fix spacing * Make format * Add make target for CometMock e2e tests * Add CometMock job to automated tests * tests: revert reducing happyPath steps count * tests: revert reducing happyPath steps count * Fix --gas auto with CometMock --------- Co-authored-by: Philip Offtermatt <[email protected]> Co-authored-by: Philip Offtermatt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1182
Integrates and enables CometMock to run in the Automated Tests.
Changes by file:
This is just to immediately see whether there are differences, i.e. if CometMock fails and regular tests don't, probably a problem of CometMock.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...