Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: store proposed chainID before voting finishes (#1289) #1338

Closed
wants to merge 1 commit into from

Conversation

yaruwangway
Copy link
Contributor

  • feat: store chain in proposal

  • add govHook

  • delete GetChainsInProposal

  • check proposal type

  • update key

  • feat: add query proposed chainIDs

  • feat: set govhook

  • feat: parse key

  • refactor: names

  • feat: add list proposed consumer chains

  • test: add e2e test

  • add e2e test

  • update comments

  • update ProposeConsumerChains in e2e test

  • remove wait for block

  • docs: update changelog

  • fix: lint

  • add TestParseProposedConsumerChainKey

  • refactor gov hook

  • Update proto/interchain_security/ccv/provider/v1/query.proto

  • update proto

  • add test for set kv

  • refactor key to be prefix_proposalID

  • formatting

  • update e2e test

  • format

  • Update x/ccv/provider/keeper/gov_hook.go

  • Update x/ccv/provider/keeper/keeper.go

  • Update x/ccv/provider/keeper/keeper.go

  • fix e2e test

  • fix gosec

  • remove type url check

  • test: add unit test

  • lint

  • fix lint

  • fix err


Please go the the Preview tab and select the appropriate sub-template:

  • Production code - for types fix, feat, and refactor.
  • Docs - for documentation changes.
  • Others - for changes that do not affect production code.

* feat: store chain in proposal

* add govHook

* delete GetChainsInProposal

* check proposal type

* update key

* feat: add query proposed chainIDs

* feat: set govhook

* feat: parse key

* refactor: names

* feat: add list proposed consumer chains

* test: add e2e test

* add e2e test

* update comments

* update ProposeConsumerChains in e2e test

* remove wait for block

* docs: update changelog

* fix: lint

* add  TestParseProposedConsumerChainKey

* refactor gov hook

* Update proto/interchain_security/ccv/provider/v1/query.proto

Co-authored-by: MSalopek <[email protected]>

* update proto

* add test for set kv

* refactor key to be prefix_proposalID

* formatting

* update e2e test

* format

* Update x/ccv/provider/keeper/gov_hook.go

Co-authored-by: Shawn <[email protected]>

* Update x/ccv/provider/keeper/keeper.go

Co-authored-by: Shawn <[email protected]>

* Update x/ccv/provider/keeper/keeper.go

Co-authored-by: Shawn <[email protected]>

* fix e2e test

* fix gosec

* remove type url check

* test: add unit test

* lint

* fix lint

* fix err

---------

Co-authored-by: MSalopek <[email protected]>
Co-authored-by: Shawn <[email protected]>
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Oct 2, 2023
@yaruwangway yaruwangway closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant