Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: GH workflow for publishing docker images #1593

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Jan 25, 2024

Description

Closes: #1592
GH workflow to publish ICS docker images

Workflow is triggerd to build

  • interchain-security:latest image when a commit is pushed to 'main' branch
  • interchain-security:vX.Y.Z when a tag with pattern vX.Y.Z is pushed
  • interchain-security:vX.Y.Z-lsm when a tag with pattern vX.Y.Z-lsm is pushed

for all other commits/tags no docker image workflow will be triggered


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@bermuell bermuell requested a review from a team as a code owner January 25, 2024 14:08
@github-actions github-actions bot added the C:CI Assigned automatically by the PR labeler label Jan 25, 2024
@bermuell bermuell marked this pull request as draft January 25, 2024 14:09
@bermuell bermuell changed the title Added GH workflow for publishing docker images ci: GH workflow for publishing docker images Jan 25, 2024
@bermuell bermuell self-assigned this Jan 25, 2024
@bermuell bermuell force-pushed the bernd/1592-publish-dockerimages branch from 377a00f to eb82497 Compare January 26, 2024 09:11
@bermuell bermuell force-pushed the bernd/1592-publish-dockerimages branch from eb82497 to fd749f4 Compare January 26, 2024 10:04
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.
Unfortunately, iirc the only realistic way to test this is to merge and
check what it publishes. An alternative might be forking the repo to informalsystems and playing with it there (at least we don't mess with the real repo)

wdyt?

@bermuell bermuell force-pushed the bernd/1592-publish-dockerimages branch 3 times, most recently from 77f9675 to fd749f4 Compare January 26, 2024 16:07
@bermuell bermuell marked this pull request as ready for review January 29, 2024 08:44
@bermuell
Copy link
Contributor Author

Looks reasonable to me. Unfortunately, iirc the only realistic way to test this is to merge and check what it publishes. An alternative might be forking the repo to informalsystems and playing with it there (at least we don't mess with the real repo)

wdyt?

yes you're right. did not find a way to test this outside the PR. will observe what is published and adapt if needed.

Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow looks good as far as I can tell, so approval and let's see whether it works as expected.

Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

Let's reduce the amount of images being pushed. The most important events happen on push to main and when a tag/release is created.

.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
@MSalopek MSalopek self-requested a review January 29, 2024 17:06
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

LGTM.

@bermuell bermuell added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit 9f375b4 Jan 29, 2024
13 checks passed
@bermuell bermuell deleted the bernd/1592-publish-dockerimages branch January 29, 2024 17:28
mergify bot pushed a commit that referenced this pull request Jan 29, 2024
* Added GH workflow for publishing docker images

* added pull request trigger

* update actions

* added match pattern for '-lsm' tags

* addressed review comments

(cherry picked from commit 9f375b4)
mergify bot pushed a commit that referenced this pull request Jan 29, 2024
* Added GH workflow for publishing docker images

* added pull request trigger

* update actions

* added match pattern for '-lsm' tags

* addressed review comments

(cherry picked from commit 9f375b4)
mergify bot pushed a commit that referenced this pull request Jan 29, 2024
* Added GH workflow for publishing docker images

* added pull request trigger

* update actions

* added match pattern for '-lsm' tags

* addressed review comments

(cherry picked from commit 9f375b4)
bermuell added a commit that referenced this pull request Feb 1, 2024
ci: GH workflow for publishing docker images (#1593)

* Added GH workflow for publishing docker images

* added pull request trigger

* update actions

* added match pattern for '-lsm' tags

* addressed review comments

(cherry picked from commit 9f375b4)

Co-authored-by: bernd-m <[email protected]>
bermuell added a commit that referenced this pull request Feb 1, 2024
ci: GH workflow for publishing docker images (#1593)

* Added GH workflow for publishing docker images

* added pull request trigger

* update actions

* added match pattern for '-lsm' tags

* addressed review comments

(cherry picked from commit 9f375b4)

Co-authored-by: bernd-m <[email protected]>
mpoke pushed a commit that referenced this pull request Feb 1, 2024
ci: GH workflow for publishing docker images (#1593)

* Added GH workflow for publishing docker images

* added pull request trigger

* update actions

* added match pattern for '-lsm' tags

* addressed review comments

(cherry picked from commit 9f375b4)

Co-authored-by: bernd-m <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CI Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build docker image of interchain-security in CI
3 participants