Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rosetta cli test #41

Merged
merged 29 commits into from
Sep 20, 2023
Merged

feat: Rosetta cli test #41

merged 29 commits into from
Sep 20, 2023

Conversation

bizk
Copy link
Contributor

@bizk bizk commented Sep 18, 2023

Closes: #23

Changes:

  • Adds Rosetta-cli test to PR process
  • Creates a test scenario against cosmos simapp
  • Improves some error messages
  • Updates on go mod

@bizk bizk changed the title Feat: Rosetta cli test feat: Rosetta cli test Sep 19, 2023
@bizk bizk self-assigned this Sep 19, 2023
@bizk bizk marked this pull request as ready for review September 20, 2023 14:27
@bizk bizk requested a review from raynaudoe September 20, 2023 15:17
@bizk bizk added the zondax label Sep 20, 2023
Copy link
Contributor

@raynaudoe raynaudoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things to tweak in the configs.

Another thing, the simapp doesn't produce any tx, meaning you have to create them manually (through a script) in order to have some data for rosetta-cli to test with.
This can be done in another PR: take into account what it was done previously here.
The ideal scenario would be having a bunch of accounts, create some transactions between them. (ideally all supported ones by rosetta) and then feed the simapp with that (I don't know the exact steps to do that, but you can explore the repo using the above file at starting point)

.github/workflows/rosetta-cli-test.yaml Show resolved Hide resolved
.github/workflows/rosetta-cli-test.yaml Show resolved Hide resolved
plugins.go Show resolved Hide resolved
tests/config/rosetta-cli.json Show resolved Hide resolved
@bizk bizk merged commit 634a81a into main Sep 20, 2023
12 checks passed
@bizk bizk deleted the feat/clitest branch September 20, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Improve CI-Tests
2 participants