Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: coinbase accurate dockerfile #70

Merged
merged 4 commits into from
Jan 10, 2024
Merged

feat: coinbase accurate dockerfile #70

merged 4 commits into from
Jan 10, 2024

Conversation

bizk
Copy link
Contributor

@bizk bizk commented Jan 1, 2024 •
edited
Loading

Modified rosetta in order to follow coinbase dockerfile requeriments.

@bizk bizk self-assigned this Jan 1, 2024
@bizk bizk marked this pull request as ready for review January 1, 2024 20:36
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jan 1, 2024 •
edited
Loading

Walkthrough

The project has undergone a significant update involving the Go language version, Docker build configuration, build process, and execution flow. The Go version has been upgraded to 1.20.7, the Dockerfile restructured for more efficient builds, the Makefile adjusted to target a new build process, and a script added to initialize services in a specific sequence upon container startup.

Changes

File(s) Change Summary
.go-version Updated to specify Go version 1.20.7.
Dockerfile Base image updated, new build stages added, source cloning and checkout modified, new file copies, entrypoint changed.
Makefile Build process updated, rosetta target replaced with build, added commands for plugin building.
scripts/entrypoint.sh New script added to launch simd, then rosetta after a delay, with specific configurations.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat with CodeRabbit Bot (@coderabbitai)

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Jan 1, 2024
View reviewed changes
scripts/entrypoint.sh Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
raynaudoe
raynaudoe requested changes Jan 8, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
@raynaudoe raynaudoe self-requested a review January 8, 2024 20:30
@bizk bizk merged commit 1d3821e into main Jan 10, 2024
6 of 10 checks passed
@bizk bizk deleted the feature/rosettaDockerfile branch January 10, 2024 16:04
@coderabbitai coderabbitai bot mentioned this pull request Apr 23, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@raynaudoe raynaudoe raynaudoe approved these changes

Assignees

@bizk bizk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bizk @raynaudoe