Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use encodeCall instead of encodeWithSelector when possible #321

Open
srdtrk opened this issue Feb 25, 2025 · 1 comment
Open

Use encodeCall instead of encodeWithSelector when possible #321

srdtrk opened this issue Feb 25, 2025 · 1 comment
Assignees
@srdtrk
Labels
enhancement Improvements solidity Issues related to the solidity contracts

Comments

@srdtrk
Copy link
Member

srdtrk commented Feb 25, 2025

We sometimes use encodeWithSelector instead of encodeCall to encode our method calls. It is type safe to use encodeCall, whereas encodeWithSelector is not type safe.
@srdtrk srdtrk mentioned this issue Feb 25, 2025
Open
6 tasks
@srdtrk srdtrk self-assigned this Feb 25, 2025
@srdtrk srdtrk added enhancement Improvements solidity Issues related to the solidity contracts labels Feb 25, 2025
@srdtrk
Copy link
Member Author

srdtrk commented Feb 25, 2025

I want to address this after #318 is merged

@github-project-automation github-project-automation bot moved this to Backlog in IBC Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srdtrk srdtrk

Labels
enhancement Improvements solidity Issues related to the solidity contracts
Projects
IBC
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srdtrk