Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to reference installation shell scripts #413

Open
deniseyu opened this issue Apr 19, 2023 · 0 comments
Open

Improvements to reference installation shell scripts #413

deniseyu opened this issue Apr 19, 2023 · 0 comments

Comments

@deniseyu
Copy link
Contributor

deniseyu commented Apr 19, 2023

just keeping track of some small improvements we can make to installation shell scripts!

  • set -ex at the top!
  • add apt update
  • see if there's a way to automatically 'Y' to the package installs
  • copy the Go binary and client binary into the system binary path, /usr/local/bin
  • more robust if [ -f "$FILE" ] checks before deleting directories - assume this will be rerun
  • run through shell check
  • use pushd and popd instead of cd
  • set GO_VERSION as a constant and template it into the Go install section
  • set optional constant for persistent peers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant