Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceCollection feedback #242

Open
MmMapIoSpace opened this issue Nov 8, 2024 · 1 comment
Open

ServiceCollection feedback #242

MmMapIoSpace opened this issue Nov 8, 2024 · 1 comment

Comments

@MmMapIoSpace
Copy link

Hi, I am very new to your library.
And this is very amazing in my opinion, the project you made, allows C# developers to know more and can create custom servers for SMTP.
But as a beginner, I have a little problem at the beginning that because you made a custom 'ServiceProvider', it was a little confusing, because at first I thought it was a ServiceProvider from Microsoft DI, but it turned out not to be, so I had already designed an application with the Worker Service template and implemented DI, and finally I changed your ServiceProvider system which forced me to have to dive into your code architecture and had a lot of problems, because if I didn't change it, it meant that every class implementation that would be added had to use manual DI and sometimes problems with the same naming also caused code conflicts, which were sometimes quite difficult to recognize when it was quite subtle.
So it would be better in my opinion if you natively implement DI from Microsoft, although it might make your library's basic dependencies also change drastically, but it would be better for better global standardization with various software architectures in the future.

Thank you

@cosullivan
Copy link
Owner

Hi,

Thanks for your feedback. It was done this way such that there were no dependencies on any specific DI container as every has their choice.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants