Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gocbcore.EncodeCommonFlags ignores compression type when it generates flags #10

Open
peczenyj opened this issue Nov 19, 2024 · 1 comment

Comments

@peczenyj
Copy link

function gocbcore.EncodeCommonFlags totally ignores the compression type when it generates a flag object

example:

	flags := gocbcore.EncodeCommonFlags(gocbcore.JSONType, gocbcore.UnknownCompression)

	_, compression := gocbcore.DecodeCommonFlags(flags)

        fmt.Println("compressio is unknown?", compression == gocbcore.UnknownCompression) // returns false

https://go.dev/play/p/Tj7yqRWHHI6

@chvck
Copy link
Contributor

chvck commented Nov 19, 2024

Hi @peczenyj thanks for filing this issue. Is this an issue that you're actually facing in something that you're trying to do? There isn't actually a common flag value for unknown compression, as per https://github.com/couchbaselabs/sdk-rfcs/blob/master/rfc/0020-common-flags.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants