Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed http request not being aborted #34

Open
pasin opened this issue May 25, 2016 · 1 comment
Open

Fixed http request not being aborted #34

pasin opened this issue May 25, 2016 · 1 comment

Comments

@pasin
Copy link
Contributor

pasin commented May 25, 2016

Currently we are using fetch polyfill which has abort feature pending as a result we couldn't really abort http requests. Fake aborting has been implemented but this doesn't well with Channels page that send longpoll requests.

We could fix this by using other http client libraries:

@pasin pasin added this to the 1.3 milestone May 25, 2016
@pasin pasin added the bug label May 25, 2016
pasin added a commit that referenced this issue May 25, 2016
This is an interim solution until fetch polyfill supports abort.

#34
@pasin
Copy link
Contributor Author

pasin commented May 25, 2016

Personally I prefer the axios library over the superagent as its API is very similar to the fetch polyfill. However they have the same issue with fetch polyfill as there is no standard way to cancel the promise. They are currently working on the solution. Once either axios or fetch polyfill has the abort feature implemented, we could just switch to use the library. Meanwhile I will keep this issue open.

@pasin pasin self-assigned this May 25, 2016
@djpongh djpongh added icebox and removed backlog labels Jan 6, 2017
@djpongh djpongh modified the milestones: 2.0.0, 2.2.0 Nov 27, 2017
@djpongh djpongh modified the milestone: 2.2.0 Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants