Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common and specific parts for provider #27

Closed
jaapterwoerds opened this issue Oct 22, 2021 · 0 comments · Fixed by #28
Closed

Extract common and specific parts for provider #27

jaapterwoerds opened this issue Oct 22, 2021 · 0 comments · Fixed by #28

Comments

@jaapterwoerds
Copy link
Contributor

jaapterwoerds commented Oct 22, 2021

While working on this PR(#16), @jrdi suggested to first do some refactoring on the provider to separate the generic and specific parts for a provider.

The simplest structure I can think of is a base class provider which takes the current provider code, wraps it in a class but leaves one method unimplemented(namely the one method which does a call to the data provider get data for one ticker for a given period).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant