Skip to content

Commit a5f2832

Browse files
chore(cd): fix cd + setup npm provenance (#74)
* chore: add npm provenance * +fix: checkout before running cd * clean eol * fix: update GitHub Actions to use checkout and setup-node v4 * fix(dep-review): add missing permission The workflow is not valid. .github/workflows/dependency-review.yml (Line: 10, Col: 3): Error calling workflow 'coveo/public-actions/.github/workflows/dependency-review.yml@main'. The nested job 'dependency-review' is requesting 'pull-requests: write', but is only allowed 'pull-requests: none'.
1 parent 099a178 commit a5f2832

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

.github/workflows/cd.yml

+6-3
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,19 @@ jobs:
88
name: CD
99
runs-on: ubuntu-latest
1010
environment: CD
11+
permissions:
12+
contents: read
13+
id-token: write
1114
steps:
12-
- uses: actions/setup-node@v3
15+
- uses: actions/checkout@v4
16+
- uses: actions/setup-node@v4
1317
with:
1418
registry-url: "https://registry.npmjs.org"
1519
node-version-file: '.nvmrc'
1620
cache: 'npm'
1721
- run: npm ci
1822
- run: npm run build
1923
- run: npm test
20-
- run: npm publish
24+
- run: npm publish --provenance --access public
2125
env:
2226
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
23-

.github/workflows/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ jobs:
1010
runs-on: ubuntu-latest
1111
name: CI
1212
steps:
13-
- uses: actions/checkout@v3
14-
- uses: actions/setup-node@v3
13+
- uses: actions/checkout@v4
14+
- uses: actions/setup-node@v4
1515
with:
1616
node-version-file: '.nvmrc'
1717
cache: 'npm'

.github/workflows/dependency-review.yml

+2
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,12 @@ on:
55

66
permissions:
77
contents: read
8+
pull-requests: write
89

910
jobs:
1011
dependency-review:
1112
uses: coveo/public-actions/.github/workflows/dependency-review.yml@main
1213
with:
1314
public: true
1415
distributed: true
16+
runs-on: '["ubuntu-latest"]'

0 commit comments

Comments
 (0)