Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Instruction and replace it with distinct types #16

Open
covercash2 opened this issue Dec 28, 2024 · 0 comments
Open

remove Instruction and replace it with distinct types #16

covercash2 opened this issue Dec 28, 2024 · 0 comments

Comments

@covercash2
Copy link
Owner

it's currently difficult go from Instruction to Modelfile::<field> because the Instruction enum is an indirection. the initial reasoning for this was to prefer built-in types where it made sense (e.g. from: String) and to avoid unnecessary or premature validation.

but i think it makes better sense to have individual types for these things even if they are just thin wrappers to give more type-safe controls over how these fields are shown, and validation can be added as it becomes necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant