fix: check API settings values before storing them in the SettingsProvider #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @covidgreen/members ... looks like this one needs review? It's been sitting here for a while |
jasnell
reviewed
Nov 17, 2020
| riskGroupMinAge: Number(apiSettings.riskGroupMinAge), | ||
| hsePhoneNumber: apiSettings.hsePhoneNumber | ||
| }); | ||
| const appConfig: AppConfig = {...defaultValue.appConfig}; |
There was a problem hiding this comment.
Super minor, but as a guard against potential performance issues elsewhere, it would be good to still predefine these properties.
Suggested change
| const appConfig: AppConfig = {...defaultValue.appConfig}; | |
| const appConfig: AppConfig = { | |
| ...defaultValue.appConfig, | |
| checkInMaxAge: undefined, | |
| riskGroupMinAge: undefined, | |
| hsePhoneNumber: undefined | |
| }; |
Same with the traceConfiguration below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #48.
It checks if the settings returned by the backend are undefined/null before setting them into the provider.