Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove en-IE from Intl.NumberFormat and create a formatNumber function #51

Open
wants to merge 1 commit into
base: current
Choose a base branch
from
Open

Refactor: remove en-IE from Intl.NumberFormat and create a formatNumber function #51

wants to merge 1 commit into from

Conversation

andreaforni
Copy link
Contributor

This PR closes #50

Add a formatNumber function that reads the current locale from i18n.

@andreaforni andreaforni self-assigned this Aug 27, 2020
@jasnell
Copy link
Contributor

jasnell commented Nov 17, 2020

Ping @covidgreen/members ... looks like this one needs review? It's been sitting here for a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floridemai floridemai floridemai approved these changes

Assignees

@andreaforni andreaforni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: remove en-IE from Intl.NumberFormat and create a formatNumber function
3 participants
@andreaforni @jasnell @floridemai