feat: expose notifications api #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
force-pushed
the
add-notifications-api
branch
from
0344b93 to
ce1dd8e
Compare
alfetopito
reviewed
Jul 31, 2024
anxolin
force-pushed
the
add-notifications-api
branch
from
f863673 to
8458d79
Compare
|
Merging to consolidate and test the release. I address issues raised after the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the notifications API in BFF.
Right now the Nofications are coming from the CMS, but some notifications can be added to some other sources (like a database, etc), also the notifications can be enhanced with on-chain data, or post-processed, for this reason, I think is convenient to expose it through BFF.
This would also allow us to remove the dependency from CoW Swap to the CMS and reduce the permissions of reading the notifications from the public endpoint (now is a securitized request)
Test
Run locally and execute:
curl -i http://localhost:3010/accounts/0x79063d9173C09887d536924E2F6eADbaBAc099f5/notifications