Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize caches #75

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Normalize caches #75

merged 2 commits into from
Jul 30, 2024

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jul 30, 2024 •
edited
Loading

This PR normalises the cache name generation.

Make cache keys coherent

Addresses this #73 (comment)

  • Makes sure the keys are lowercase
  • Provide a convenient way to generate the keys consistently across the app
  • The cache keys will use now kebab keys instead of camel case, so we can keep all keys lower case

BONUS: Use collon (:) instead of slash (/) for paths keys

Fixes #72

@anxolin anxolin changed the base branch from main to implement-multi-chain-support-for-cow July 30, 2024 15:07
@anxolin anxolin marked this pull request as ready for review July 30, 2024 15:10
@anxolin anxolin requested a review from a team July 30, 2024 15:10
@anxolin anxolin mentioned this pull request Jul 30, 2024
Merged
@anxolin anxolin mentioned this pull request Jul 30, 2024
Merged
@anxolin anxolin force-pushed the implement-multi-chain-support-for-cow branch from 89aca91 to 222955f Compare July 30, 2024 15:56
@anxolin anxolin force-pushed the normalize-caches branch from 0282d7b to 979330d Compare July 30, 2024 15:57
@anxolin anxolin force-pushed the implement-multi-chain-support-for-cow branch from 222955f to a8ff1aa Compare July 30, 2024 16:01
Base automatically changed from implement-multi-chain-support-for-cow to main July 30, 2024 16:03
@anxolin anxolin force-pushed the normalize-caches branch from 979330d to 196d8fd Compare July 30, 2024 16:03
@anxolin anxolin merged commit f244bc8 into main Jul 30, 2024
6 checks passed
@anxolin anxolin deleted the normalize-caches branch July 30, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfetopito alfetopito alfetopito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redis cache - Use collon (:) instead of / for keys
2 participants
@anxolin @alfetopito