chore: migrate tests to solidity #106
Assignees
Labels
E:5.2 Contracts migrations
See https://github.com/cowprotocol/pm/issues/32 for details
help wanted
Extra attention is needed
Comments
22 tasks
mfw78
added
the
E:5.2 Contracts migrations
Merged
fedgiac
added a commit
that referenced
this issue
Jun 4, 2024
## Description Coveralls is noisy, since it started adding a message to each PR since a while ago. We are also going to break full coverage while we migrate tests gradually from Hardhat to Foundry. This PR removes Coveralls from this repo. ## Test Plan See no new message on CI. ## Related Issues #106
Merged
mfw78
added a commit
that referenced
this issue
Jun 5, 2024
## Description This PR bumps the pragma to support up-to-and-including solidity (`0.8.26`). This allows the foundry migration taking place to have tests written in solc `0.8.x`, reducing redundancy / effort with writing the associated test contracts. It is important that the `bytecode` generated for production still be compliant with `0.7.6` (save for potential issues associated with the `metadata` hash appended by `solc`). To facilitate this, the `test` pipeline uses a multi-version matrix strategy to ensure that the contracts remain able to be built with `0.7.6`. A minor miscellaneous patch is also included for VS Code's solidity configuration, reducing configuration size. ## Test Plan 1. Verify `test` CI/CD runs `0.7.6` and `0.8.26` matrices. 2. Verify that the `ci` CI/CD runs (`hardhat`) and completes successfully. ## Related Issues Related: #106 --------- Co-authored-by: Federico Giacon <[email protected]>
kamuik16
pushed a commit
to kamuik16/contracts
that referenced
this issue
Jun 5, 2024
## Description This PR bumps the pragma to support up-to-and-including solidity (`0.8.26`). This allows the foundry migration taking place to have tests written in solc `0.8.x`, reducing redundancy / effort with writing the associated test contracts. It is important that the `bytecode` generated for production still be compliant with `0.7.6` (save for potential issues associated with the `metadata` hash appended by `solc`). To facilitate this, the `test` pipeline uses a multi-version matrix strategy to ensure that the contracts remain able to be built with `0.7.6`. A minor miscellaneous patch is also included for VS Code's solidity configuration, reducing configuration size. ## Test Plan 1. Verify `test` CI/CD runs `0.7.6` and `0.8.26` matrices. 2. Verify that the `ci` CI/CD runs (`hardhat`) and completes successfully. ## Related Issues Related: cowprotocol#106 --------- Co-authored-by: Federico Giacon <[email protected]>
mfw78
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
There is a comprehensive test suite that needs to be migrated from
hardhattofoundry.External contributors
Upon completion of reference unit test and/or reference E2E test, external contributors are invited to contribute to the code base in the migration from hardhat to foundry for subsequent unit / E2E tests.
Work plan
a. The foundry tests
b. Deleted the associated hardhat tests that were migrated
c. Run
forge fmton the source code files that were added.Tasks
GPv2AllowListAuthenticator#115GPv2Interaction#116GPv2Order#117GPv2SafeERC20#118GPv2Settlement#119GPv2Signing#120GPv2Trade#121GPv2TradeSimulator#122GPv2Transfer#123GPv2VaultRelayer#124AllowListStorageReader#125decoding#126SettlementStorageReader#127sign#1280xTrade#131zero-ex v2#132balancerSwap#133burnFees#134buyEth#135contractOrdersWithGnosisSafe#136internalBalances#137nonStandardERC20#138offchainAllowances#139simulateTrade#140uniswapTrade#141upgradeAuthenticator#142wineOilMarket#143StorageAccessible#145StorageReadable#146ViewStorageAccessible#147deployment#149transferOwnership#150The text was updated successfully, but these errors were encountered: