Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base deployment to v1 #235

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Base deployment to v1 #235

merged 1 commit into from
Dec 5, 2024

Conversation

fedgiac
Copy link
Contributor

@fedgiac fedgiac commented Dec 4, 2024

Description

The code in this PR is the result of checking out the v1 branch (based on current v1.6.0) and running git cherry-pick f3a13f861e9c1cdbcee036d024849a838cbf7f82.

We're creating the new v1 branch to make it easier to organize the minimal changes required to support the Base network on top of v1.6.0. This is made necessary by the fact that the recent changes have stripped this repo of most of the JS libraries provided by the NPM package.

Eventually, we plan to deprecate all the JS libraries provided by this repo and only include contract/Foundry code.

## Description
Deployed contracts in Base chain. Settlement contract:
https://basescan.org/address/0x9008D19f58AAbD9eD0D60971565AA8510560ab41

Verified all contracts in Tenderly ✔️ 
Verified all contracts except `EIP173Proxy` in Basescan.
Copy link

Report too large to display inline

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/[email protected] ⚠︎
Critical CVE npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@fedgiac fedgiac requested a review from shoom3301 December 4, 2024 17:16
fedgiac added a commit that referenced this pull request Dec 5, 2024
## Description

There is little JS code remaining in the `main` branch.
This PR makes it clear that there is no NPM package available for this
code (at least yet) and that maintenance work on the current package has
moved to the [`v1`
branch](#235 (comment)).
@fedgiac fedgiac requested a review from m-lord-renkse December 5, 2024 13:55
@fedgiac fedgiac merged commit 196fbd6 into v1 Dec 5, 2024
5 checks passed
@fedgiac fedgiac deleted the base-to-v1 branch December 5, 2024 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants