Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder action to publish to NPM #238

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

fedgiac
Copy link
Contributor

@fedgiac fedgiac commented Dec 5, 2024

Description

Commit 0bdf44c removes the GitHub Action to publish to NPM.

This action is supposed to be available only on branch v1, however GitHub requires workflow_dispatch actions to appear on the default branch in order to be triggered through the Action overview page. From the docs:

This trigger only receives events when the workflow file is on the default branch.

This PR creates a no-op action that would make it possible to trigger the action with the same name on v1.
There appear to be workarounds to not pollute the default branch, however the approach of recreating the action on main seems less likely to break in the future.

Test Plan

Compare with the corresponding action on v1 and confirm that the name and references are the same.

@fedgiac fedgiac requested a review from shoom3301 December 5, 2024 15:54
@fedgiac fedgiac requested a review from a team as a code owner December 5, 2024 15:54
@fedgiac fedgiac merged commit 9c1984b into main Dec 5, 2024
8 checks passed
@fedgiac fedgiac deleted the placeholder-npm-publish-action-for-github branch December 5, 2024 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants