Change naming of start and end time #46
Conversation
from StartTime to start_time from EndTime to end_time
this caused an issue with tests
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: pypi/[email protected] |
| @@ -18,7 +18,8 @@ def test_query_runner(self, mocked_post): | |||
| query = load_config(filepath("v2-test-data.yaml")).query | |||
| dune = DuneClient(os.environ["DUNE_API_KEY"]) | |||
| slack_client = BasicSlackClient(token="Fake Token", channel="Fake Channel") | |||
| query_runner = QueryRunner(query, dune, slack_client) | |||
| ping_frequency = 10 | |||
There was a problem hiding this comment.
what exactly is this adding? Noticed this is in the tests so not clear what the purpose of this change is
There was a problem hiding this comment.
My guess is that the default ping frequency was lowered to 1 second in the client package and so the test was producing an unnecessary number of logs. Back when this was built the default ping frequency was 10. But dune has faster engines now so it was lowered.
There was a problem hiding this comment.
It was just that (on my machine) running the tests was not possible since ping_frequency was a required parameter.
I did not want to look at updating/checking dependencies so just provided a value which seemed reasonable.
It looks like a reasonable approach, which is however not compatible with how Dune set up their new query view feature. See limitation 5 here. Maybe camel case would have worked as well. So the examples in the Dune documentation are wrong/misleading) |
This PR closes #45.