New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last Sync - Improvements #16

Open

bh2smith opened this issue Dec 7, 2022 · 0 comments

Contributor

bh2smith commented Dec 7, 2022

@MartinquaXD raised some good (non-blocking) points of improvement for the already merged code in #12. Here I will try to summarize;

No need for Optional Block Number. This is only used for testing purposes and the tests could be adapted instead of the return type.
Throw error on invalid table name. I think the problem with this may be that our test tables write to a different directory (intentionally) so not to interfere with real data. I think we may want to keep this.... not sure.
Look at when KeyError occurs
Use Contract Deployment as default genesis block

I think items 1 and 4 are the most straight forward to change first, still not sure yet about the other two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment