Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mirror] Use scores instead of surplus for reward computation #104

Merged
merged 3 commits into from
Jul 12, 2024
Merged

[Mirror] Use scores instead of surplus for reward computation #104

merged 3 commits into from
Jul 12, 2024

Conversation

fhenneke
Copy link
Contributor

@fhenneke fhenneke commented Jul 11, 2024 •
edited
Loading

This PR mirrors changes from cowprotocol/solver-rewards#372

The changes in the test are due to rounding errors in computing scores in the driver and in the old SQL query.

@fhenneke fhenneke requested a review from harisang July 11, 2024 13:00
harisang
harisang approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@harisang harisang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical to solver rewards PR that i reviewed and tested

@harisang harisang merged commit d3b054d into main Jul 12, 2024
6 checks passed
@harisang harisang deleted the reward_from_scores branch July 12, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harisang harisang harisang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhenneke @harisang