Remove special handling of empty dataframes #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the assert is not required in the remainder of the code, as individual rows are just uploaded to dune as is
bram-vdberg
approved these changes
Oct 25, 2024
|
|
The change is not correct as it would still lead to a A full fix would require also changing the creation of the dataframe to use no types or compatible types. Closing this for now as there are more important changes to work on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies how dataframes are concatenated after fetching from prod and barn. The behavior should be identical, except for the unnecessary copies.
The change was introduces in #85 to avoid a deprecation warning. This is not required anymore.