[Hotfix] Update latest block query #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the format of the settlements table will be changed. instead of looking at the earlies block without some transaction data we now look at the latest block with settlement observations this should work with both the new and old format of the settlements table
harisang
reviewed
Jan 26, 2024
harisang
approved these changes
Jan 26, 2024
Closed
fhenneke
added a commit
that referenced
this pull request
Feb 5, 2024
This PR addresses issue #72. At the moment the block range is computed using the minimum of the latest finalized block from production and staging and subtracting `REORG_THRESHOLD = 65`. This was done as a hot fix in #71. One problem with this approach is that having few settlements in staging blocks upload of production data to dune. This PR changes the behavior to look at the maximum block of the latest finalized blocks from production and staging subtracting `MAX_PROCESSING_DELAY = 1`. This should leave enough time for the autopilot to process settlements after finalization in staging and production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dune uploads are broken at the moment due to a change to the
settlementstable in our database. This PR changes the query to be compatible with that change.Instead of looking at the earliest block without some transaction data in the
settlementstable we now look at the latest block in thesettlement_observationstable.This should work with both the new and old format of the settlements table.
Tests passed locally.