Fix dataframe warning #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
approved these changes
Mar 5, 2024
Comment on lines
+91
to
+97
| if not prod.empty and not barn.empty: | ||
| return pd.concat([prod, barn]) | ||
| if not prod.empty: | ||
| return prod.copy() | ||
| if not barn.empty: | ||
| return barn.copy() | ||
| return pd.DataFrame() |
There was a problem hiding this comment.
Looks like it does what it is supposed to. The following looks more pythonic, but I have not tested it.
Suggested change
| if not prod.empty and not barn.empty: | |
| return pd.concat([prod, barn]) | |
| if not prod.empty: | |
| return prod.copy() | |
| if not barn.empty: | |
| return barn.copy() | |
| return pd.DataFrame() | |
| return pd.concat(df for df in [prod, barn] if not df.empty) |
There was a problem hiding this comment.
Yeah agreed but i don't feel that comfortable with all these compact pythonic ways, so if you don't mind, i want to test it as is and then we can potentially make it nicer in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #82